Fix globals' type deduction in TypeScavenger#2431
Merged
MrSidims merged 1 commit intoKhronosGroup:mainfrom Mar 18, 2024
Merged
Conversation
|
|
mshelego
force-pushed
the
opaque_getelementrptr
branch
from
7e2fad8 to
cee3358
Compare
If a global is initialized with a ConstantExpr returning a pointer (getelementptr), the right type has to be deduced instead of defaulting it to i8*.
mshelego
force-pushed
the
opaque_getelementrptr
branch
from
cee3358 to
3434dca
Compare
vmaksimo
approved these changes
Mar 18, 2024
svenvh
approved these changes
Mar 18, 2024
Contributor
|
/backport llvm_release_180 |
|
Attempting to create backport to |
github-actions bot
pushed a commit
that referenced
this pull request
Mar 3, 2026
If a global is initialized with a ConstantExpr returning a pointer (getelementptr), the right type has to be deduced instead of defaulting it to i8*.
|
Success. Backport PR created: #3613 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a global is initialized with a ConstantExpr returning a pointer (getelementptr), the right type has to be deduced instead of defaulting it to i8*.