Skip to content

Conversation

@asudarsa
Copy link
Contributor

There are scenarios where users define functions with names as 'atomic_fetch_and_sub_uint32'. Such functions are being wrongly identified as OpenCL builtins.
This change adds the following to OCLIsBuiltin(...) function
if (!F->isDeclaration()) return false;

This resolves several existing test failures.

Thanks

@asudarsa
Copy link
Contributor Author

A better solution has been submitted here: #2525
Once approved, I will close this one.

Thanks

@CLAassistant
Copy link

CLAassistant commented Feb 10, 2025

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants