[LLVM->SPV-IR] Add const to pointer arg of prefetch, change num_elements arg type to unsigned#3188
Merged
svenvh merged 2 commits intoKhronosGroup:mainfrom Jun 2, 2025
Conversation
…unsigned Per SPIR-V OpenCL.ExtendedInstructionSet spec, the num_elements arg must be size_t. So this PR changes its type to unsigned in SPV-IR.
wenju-he
changed the title
svenvh
approved these changes
May 28, 2025
Contributor
Author
vmaksimo
pushed a commit
that referenced
this pull request
Feb 18, 2026
…change num_elements arg type to unsigned (#3188) Per SPIR-V OpenCL.ExtendedInstructionSet spec, the num_elements arg must be size_t. So this PR changes its type to unsigned in SPV-IR. Adding const to pointer arg aligns with OpenCL spec and allows const pointer input.
vmaksimo
added a commit
to vmaksimo/SPIRV-LLVM-Translator
that referenced
this pull request
Feb 18, 2026
… change num_elements arg type to unsigned (KhronosGroup#3188) Per SPIR-V OpenCL.ExtendedInstructionSet spec, the num_elements arg must be size_t. So this PR changes its type to unsigned in SPV-IR. Adding const to pointer arg aligns with OpenCL spec and allows const pointer input.
vmaksimo
added a commit
to vmaksimo/SPIRV-LLVM-Translator
that referenced
this pull request
Feb 18, 2026
… change num_elements arg type to unsigned (KhronosGroup#3188) Per SPIR-V OpenCL.ExtendedInstructionSet spec, the num_elements arg must be size_t. So this PR changes its type to unsigned in SPV-IR. Adding const to pointer arg aligns with OpenCL spec and allows const pointer input.
vmaksimo
added a commit
to vmaksimo/SPIRV-LLVM-Translator
that referenced
this pull request
Feb 18, 2026
… change num_elements arg type to unsigned (KhronosGroup#3188) Per SPIR-V OpenCL.ExtendedInstructionSet spec, the num_elements arg must be size_t. So this PR changes its type to unsigned in SPV-IR. Adding const to pointer arg aligns with OpenCL spec and allows const pointer input.
vmaksimo
added a commit
that referenced
this pull request
Mar 17, 2026
… change num_elements arg type to unsigned (#3188) Per SPIR-V OpenCL.ExtendedInstructionSet spec, the num_elements arg must be size_t. So this PR changes its type to unsigned in SPV-IR. Adding const to pointer arg aligns with OpenCL spec and allows const pointer input.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per SPIR-V OpenCL.ExtendedInstructionSet spec, the num_elements arg must be size_t. So this PR changes its type to unsigned in SPV-IR.
Adding const to pointer arg aligns with OpenCL spec and allows const pointer input.