Fix crash on coopmat conversion without decoration#3190
Merged
svenvh merged 1 commit intoKhronosGroup:mainfrom May 30, 2025
Merged
Fix crash on coopmat conversion without decoration#3190svenvh merged 1 commit intoKhronosGroup:mainfrom
svenvh merged 1 commit intoKhronosGroup:mainfrom
Conversation
The SPIR-V reader would crash on the added test during reverse translation. Ensure any cooperative matrix type conversion is handled the same way as a cooperative matrix type conversion with an FPRoundingMode or SaturatedConversion decoration.
vmaksimo
approved these changes
May 30, 2025
Contributor
vmaksimo
left a comment
vmaksimo
left a comment
There was a problem hiding this comment.
LGTM.
I don't know why we didn't encounter any problems before this fix, but I also can't find why the intel/llvm frontend couldn't generate conversion instructions without rounding or saturation mode.
Either we are lucky, or we just do not generate such IR to cope with this very translation issue.
Member
Author
|
/backport llvm_release_200 |
|
Attempting to create backport to |
github-actions bot
pushed a commit
that referenced
this pull request
May 30, 2025
The SPIR-V reader would crash on the added test during reverse translation. Ensure any cooperative matrix type conversion is handled the same way as a cooperative matrix type conversion with an FPRoundingMode or SaturatedConversion decoration.
|
Success. Backport PR created: #3192 |
Member
Author
|
/backport llvm_release_190 |
|
Attempting to create backport to |
github-actions bot
pushed a commit
that referenced
this pull request
May 30, 2025
The SPIR-V reader would crash on the added test during reverse translation. Ensure any cooperative matrix type conversion is handled the same way as a cooperative matrix type conversion with an FPRoundingMode or SaturatedConversion decoration.
|
Success. Backport PR created: #3193 |
Member
Author
|
/backport llvm_release_180 |
|
Attempting to create backport to |
github-actions bot
pushed a commit
that referenced
this pull request
May 30, 2025
The SPIR-V reader would crash on the added test during reverse translation. Ensure any cooperative matrix type conversion is handled the same way as a cooperative matrix type conversion with an FPRoundingMode or SaturatedConversion decoration.
|
Success. Backport PR created: #3194 |
svenvh
added a commit
to svenvh/SPIRV-LLVM-Translator
that referenced
this pull request
May 30, 2025
…hronosGroup#3190) The SPIR-V reader would crash on the added test during reverse translation. Ensure any cooperative matrix type conversion is handled the same way as a cooperative matrix type conversion with an FPRoundingMode or SaturatedConversion decoration. (cherry picked from commit 32738f9)
svenvh
added a commit
to svenvh/SPIRV-LLVM-Translator
that referenced
this pull request
Jun 3, 2025
…hronosGroup#3190) The SPIR-V reader would crash on the added test during reverse translation. Ensure any cooperative matrix type conversion is handled the same way as a cooperative matrix type conversion with an FPRoundingMode or SaturatedConversion decoration. (cherry picked from commit 32738f9)
svenvh
added a commit
to svenvh/SPIRV-LLVM-Translator
that referenced
this pull request
Jun 3, 2025
…hronosGroup#3190) The SPIR-V reader would crash on the added test during reverse translation. Ensure any cooperative matrix type conversion is handled the same way as a cooperative matrix type conversion with an FPRoundingMode or SaturatedConversion decoration. (cherry picked from commit 32738f9)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SPIR-V reader would crash on the added test during reverse translation. Ensure any cooperative matrix type conversion is handled the same way as a cooperative matrix type conversion with an FPRoundingMode or SaturatedConversion decoration.