Update tests after OpenCLKernel attribute rename#3216
Merged
MrSidims merged 1 commit intoKhronosGroup:mainfrom Jun 12, 2025
Merged
Update tests after OpenCLKernel attribute rename#3216MrSidims merged 1 commit intoKhronosGroup:mainfrom
MrSidims merged 1 commit intoKhronosGroup:mainfrom
Conversation
Update after llvm-project commit 3b9ebe92011b ("[clang] Simplify
device kernel attributes (#137882)", 2025-06-05).
MrSidims
approved these changes
Jun 10, 2025
Contributor
MrSidims
left a comment
There was a problem hiding this comment.
Probably also make sense to update https://github.com/KhronosGroup/SPIRV-LLVM-Translator/blob/main/test/transcoding/annotation_dbg_info_drop.ll while we are here
Member
Author
Nice catch; I wondered why that test didn't fail, turns out it was XFAILed: Perhaps it's time to remove this test, given that debug info intrinsics are being retired; or do you think the original problem covered by this test may still occur with the new debug info record infrastructure? |
Contributor
|
@svenvh oh, I haven't noticed, that it's XFAILed. Let me cover this later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update after llvm-project commit 3b9ebe92011b ("[clang] Simplify device kernel attributes (#137882)", 2025-06-05).