Fix error propagation in parseSPIRV#3362
Merged
MrSidims merged 1 commit intoKhronosGroup:mainfrom Sep 26, 2025
Merged
Conversation
d54f77c ("[NFC] Split of SPT and SPIR-V in header parsing (KhronosGroup#2316)", 2024-03-11) made a copy of the error log, with the presumably unintended consequence that errors are no longer propagated back to the SPIRVModule itself.
MrSidims
approved these changes
Sep 26, 2025
Member
Author
|
/backport llvm_release_210 |
Member
Author
|
/backport llvm_release_200 |
Member
Author
|
/backport llvm_release_190 |
|
Attempting to create backport to |
|
Attempting to create backport to |
|
Success. Backport PR created: #3363 |
|
Success. Backport PR created: #3364 |
|
Attempting to create backport to |
|
Success. Backport PR created: #3365 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
d54f77c ("[NFC] Split of SPT and SPIR-V in header parsing (#2316)", 2024-03-11) made a copy of the error log, with the presumably unintended consequence that errors are no longer propagated back to the SPIRVModule itself.