Skip to content

[NFCI] Remove getLifetimeStartIntrinsic function from SPIRVReader #3373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MrSidims merged 2 commits into from
Oct 2, 2025
Merged

[NFCI] Remove getLifetimeStartIntrinsic function from SPIRVReader #3373

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6489794
wip
Oct 1, 2025
a64d6a4
[NFCI] Remove getLifetimeStartIntrinsic function from SPIRVReader
Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions lib/SPIRV/SPIRVReader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,23 +249,6 @@ translateSEVMetadata(SPIRVValue *BV, llvm::LLVMContext &Context) {
return RetAttr;
}

IntrinsicInst *SPIRVToLLVM::getLifetimeStartIntrinsic(Instruction *I) {
auto *II = dyn_cast<IntrinsicInst>(I);
if (II && II->getIntrinsicID() == Intrinsic::lifetime_start)
return II;
// Bitcast might be inserted during translation of OpLifetimeStart
auto *BC = dyn_cast<BitCastInst>(I);
if (BC) {
for (const auto &U : BC->users()) {
II = dyn_cast<IntrinsicInst>(U);
if (II && II->getIntrinsicID() == Intrinsic::lifetime_start)
return II;
;
}
}
return nullptr;
}

SPIRVErrorLog &SPIRVToLLVM::getErrorLog() { return BM->getErrorLog(); }

void SPIRVToLLVM::setCallingConv(CallInst *Call) {
Expand Down Expand Up @@ -1884,9 +1867,6 @@ Value *SPIRVToLLVM::transValueWithoutDecoration(SPIRVValue *BV, Function *F,
IRBuilder<> Builder(BB);
auto *Var = transValue(LTStop->getObject(), F, BB);
Var = Var->stripPointerCasts();
for (const auto &I : Var->users())
if (auto *II = getLifetimeStartIntrinsic(dyn_cast<Instruction>(I)))
return mapValue(BV, Builder.CreateLifetimeEnd(II->getOperand(0)));
return mapValue(BV, Builder.CreateLifetimeEnd(Var));
}

Expand Down