Follow-up: Use IRParser instead of BitcodeReader #3405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since now llvm-spirv can consume textual llvm-ir, remove this pattern from the tests: ``` llvm-as %s -o %t.bc llvm-spirv %t.bc ... ```
jmmartinez
force-pushed
the
read_bitcode_followup
branch
from
b333636 to
356a522
Compare
MrSidims
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up of #3399 .
After #3399, we do not need to run
llvm-as, we can directly consume the textual llvm-ir representation.This patch profits from this to clean this pattern in the test:
And replaces it by