Fix backward translation of `OpFmaKHR` by vmaksimo · Pull Request #3529 · KhronosGroup/SPIRV-LLVM-Translator

vmaksimo · 2026-01-22T10:59:34Z

Semantically it directly maps to the LLVM fma intrnsic, so we should translate this inst back to intrinsic.

Semantically it clearly maps to the LLVM fma intrnsic, so we should translate this inst back to intrinsic.

vmaksimo · 2026-01-22T11:21:24Z

FYI @wenju-he @aratajew

wenju-he · 2026-01-22T11:45:01Z

LGTM, thanks @vmaksimo

YixingZhang007

LGTM! Thank you!

vmaksimo · 2026-01-27T14:08:32Z

/backport llvm_release_210

github-actions · 2026-01-27T14:08:55Z

Attempting to create backport to llvm_release_210...

Semantically it directly maps to the LLVM fma intrnsic, so we should translate this instruction back to intrinsic.

github-actions · 2026-01-27T14:08:59Z

Success. Backport PR created: #3537

vmaksimo · 2026-01-27T15:18:29Z

/backport llvm_release_200

github-actions · 2026-01-27T15:21:29Z

Attempting to create backport to llvm_release_200...

Semantically it directly maps to the LLVM fma intrnsic, so we should translate this instruction back to intrinsic.

github-actions · 2026-01-27T15:21:34Z

Success. Backport PR created: #3539

vmaksimo · 2026-01-27T15:21:56Z

/backport llvm_release_190

github-actions · 2026-01-27T15:24:49Z

Attempting to create backport to llvm_release_190...

Semantically it directly maps to the LLVM fma intrnsic, so we should translate this instruction back to intrinsic.

github-actions · 2026-01-27T15:24:53Z

Success. Backport PR created: #3540

vmaksimo · 2026-01-27T17:20:41Z

/backport llvm_release_180

github-actions · 2026-01-27T17:20:55Z

Attempting to create backport to llvm_release_180...

Semantically it directly maps to the LLVM fma intrnsic, so we should translate this instruction back to intrinsic.

github-actions · 2026-01-27T17:20:58Z

Success. Backport PR created: #3541

vmaksimo · 2026-01-27T17:27:07Z

/backport llvm_release_170

vmaksimo · 2026-01-27T17:52:17Z

/backport llvm_release_160

github-actions · 2026-01-27T17:54:18Z

Attempting to create backport to llvm_release_160...

Semantically it directly maps to the LLVM fma intrnsic, so we should translate this instruction back to intrinsic.

github-actions · 2026-01-27T17:54:22Z

Success. Backport PR created: #3543

vmaksimo · 2026-01-28T15:58:18Z

/backport llvm_release_220

github-actions · 2026-01-28T15:58:34Z

Attempting to create backport to llvm_release_220...

Semantically it directly maps to the LLVM fma intrnsic, so we should translate this instruction back to intrinsic.

github-actions · 2026-01-28T15:58:38Z

Success. Backport PR created: #3548

…#3539) Backport of PR #3529 into `llvm_release_200`. All commits applied cleanly. Co-authored-by: Viktoria Maximova <viktoria.maksimova@intel.com>

…#3540) Backport of PR #3529 into `llvm_release_190`. All commits applied cleanly. Co-authored-by: Viktoria Maximova <viktoria.maksimova@intel.com>

…#3541) Backport of PR #3529 into `llvm_release_180`. All commits applied cleanly. Co-authored-by: Viktoria Maximova <viktoria.maksimova@intel.com>

…#3542) Backport of PR #3529 into `llvm_release_170`. All commits applied cleanly. Co-authored-by: Viktoria Maximova <viktoria.maksimova@intel.com>

…#3543) Backport of PR #3529 into `llvm_release_160`. All commits applied cleanly. Co-authored-by: Viktoria Maximova <viktoria.maksimova@intel.com>

vmaksimo · 2026-01-29T12:50:09Z

/backport llvm_release_150

github-actions · 2026-01-29T12:50:23Z

Attempting to create backport to llvm_release_150...

Semantically it directly maps to the LLVM fma intrnsic, so we should translate this instruction back to intrinsic.

github-actions · 2026-01-29T12:50:27Z

Success. Backport PR created: #3551

vmaksimo · 2026-01-29T12:50:40Z

/backport llvm_release_140

github-actions · 2026-01-29T12:51:42Z

Attempting to create backport to llvm_release_140...

Semantically it directly maps to the LLVM fma intrnsic, so we should translate this instruction back to intrinsic.

github-actions · 2026-01-29T12:51:45Z

Success. Backport PR created: #3552

…#3551) Backport of PR #3529 into `llvm_release_150`. All commits applied cleanly. Co-authored-by: Viktoria Maximova <viktoria.maksimova@intel.com>

…#3552) Backport of PR #3529 into `llvm_release_140`. All commits applied cleanly. Co-authored-by: Viktoria Maximova <viktoria.maksimova@intel.com>

…#3537) Backport of PR #3529 into `llvm_release_210`. All commits applied cleanly. Co-authored-by: Viktoria Maximova <viktoria.maksimova@intel.com>

…#3548) Backport of PR #3529 into `llvm_release_220`. All commits applied cleanly. Co-authored-by: Viktoria Maximova <viktoria.maksimova@intel.com>

…KhronosGroup#3542) Backport of PR KhronosGroup#3529 into `llvm_release_170`. All commits applied cleanly. Co-authored-by: Viktoria Maximova <viktoria.maksimova@intel.com>

Fix backward translation of OpFmaKHR

f94ffeb

Semantically it clearly maps to the LLVM fma intrnsic, so we should translate this inst back to intrinsic.

vmaksimo requested review from YixingZhang007 and svenvh January 22, 2026 11:21

MrSidims approved these changes Jan 22, 2026

View reviewed changes

svenvh approved these changes Jan 22, 2026

View reviewed changes

YixingZhang007 approved these changes Jan 23, 2026

View reviewed changes

vmaksimo merged commit 60fa4bf into KhronosGroup:main Jan 26, 2026
7 of 9 checks passed

github-actions bot pushed a commit that referenced this pull request Jan 27, 2026

Fix backward translation of OpFmaKHR (#3529)

b784866

Semantically it directly maps to the LLVM fma intrnsic, so we should translate this instruction back to intrinsic.

github-actions bot mentioned this pull request Jan 27, 2026

[Backport to llvm_release_210] Fix backward translation of OpFmaKHR #3537

Merged

github-actions bot pushed a commit that referenced this pull request Jan 27, 2026

Fix backward translation of OpFmaKHR (#3529)

97c541c

Semantically it directly maps to the LLVM fma intrnsic, so we should translate this instruction back to intrinsic.

github-actions bot mentioned this pull request Jan 27, 2026

[Backport to llvm_release_200] Fix backward translation of OpFmaKHR #3539

Merged

github-actions bot pushed a commit that referenced this pull request Jan 27, 2026

Fix backward translation of OpFmaKHR (#3529)

bb778ba

Semantically it directly maps to the LLVM fma intrnsic, so we should translate this instruction back to intrinsic.

github-actions bot mentioned this pull request Jan 27, 2026

[Backport to llvm_release_190] Fix backward translation of OpFmaKHR #3540

Merged

github-actions bot pushed a commit that referenced this pull request Jan 27, 2026

Fix backward translation of OpFmaKHR (#3529)

57ffaa0

Semantically it directly maps to the LLVM fma intrnsic, so we should translate this instruction back to intrinsic.

github-actions bot mentioned this pull request Jan 27, 2026

[Backport to llvm_release_180] Fix backward translation of OpFmaKHR #3541

Merged

github-actions bot pushed a commit that referenced this pull request Jan 27, 2026

Fix backward translation of OpFmaKHR (#3529)

bdc9454

Semantically it directly maps to the LLVM fma intrnsic, so we should translate this instruction back to intrinsic.

github-actions bot mentioned this pull request Jan 27, 2026

[Backport to llvm_release_160] Fix backward translation of OpFmaKHR #3543

Merged

github-actions bot pushed a commit that referenced this pull request Jan 28, 2026

Fix backward translation of OpFmaKHR (#3529)

17060bd

Semantically it directly maps to the LLVM fma intrnsic, so we should translate this instruction back to intrinsic.

github-actions bot mentioned this pull request Jan 28, 2026

[Backport to llvm_release_220] Fix backward translation of OpFmaKHR #3548

Merged

github-actions bot pushed a commit that referenced this pull request Jan 29, 2026

Fix backward translation of OpFmaKHR (#3529)

1118cf1

Semantically it directly maps to the LLVM fma intrnsic, so we should translate this instruction back to intrinsic.

github-actions bot mentioned this pull request Jan 29, 2026

[Backport to llvm_release_150] Fix backward translation of OpFmaKHR #3551

Merged

github-actions bot pushed a commit that referenced this pull request Jan 29, 2026

Fix backward translation of OpFmaKHR (#3529)

fe48b88

Semantically it directly maps to the LLVM fma intrnsic, so we should translate this instruction back to intrinsic.

github-actions bot mentioned this pull request Jan 29, 2026

[Backport to llvm_release_140] Fix backward translation of OpFmaKHR #3552

Merged

Conversation

vmaksimo commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vmaksimo commented Jan 22, 2026

Uh oh!

wenju-he commented Jan 22, 2026

Uh oh!

YixingZhang007 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vmaksimo commented Jan 27, 2026

Uh oh!

github-actions bot commented Jan 27, 2026

Uh oh!

github-actions bot commented Jan 27, 2026

Uh oh!

vmaksimo commented Jan 27, 2026

Uh oh!

github-actions bot commented Jan 27, 2026

Uh oh!

github-actions bot commented Jan 27, 2026

Uh oh!

vmaksimo commented Jan 27, 2026

Uh oh!

github-actions bot commented Jan 27, 2026

Uh oh!

github-actions bot commented Jan 27, 2026

Uh oh!

vmaksimo commented Jan 27, 2026

Uh oh!

github-actions bot commented Jan 27, 2026

Uh oh!

github-actions bot commented Jan 27, 2026

Uh oh!

vmaksimo commented Jan 27, 2026

Uh oh!

vmaksimo commented Jan 27, 2026

Uh oh!

github-actions bot commented Jan 27, 2026

Uh oh!

github-actions bot commented Jan 27, 2026

Uh oh!

vmaksimo commented Jan 28, 2026

Uh oh!

github-actions bot commented Jan 28, 2026

Uh oh!

github-actions bot commented Jan 28, 2026

Uh oh!

vmaksimo commented Jan 29, 2026

Uh oh!

github-actions bot commented Jan 29, 2026

Uh oh!

github-actions bot commented Jan 29, 2026

Uh oh!

vmaksimo commented Jan 29, 2026

Uh oh!

github-actions bot commented Jan 29, 2026

Uh oh!

github-actions bot commented Jan 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

vmaksimo commented Jan 22, 2026 •

edited

Loading