Add SPV_ALTERA_arbitrary_precision_integers#3606
Merged
MrSidims merged 1 commit intoKhronosGroup:mainfrom Feb 26, 2026
Merged
Conversation
When both SPV_ALTERA_arbitrary_precision_integers and SPV_INTEL_arbitrary_precision_integers extensions are enabled - INTEL's version takes priority. Addresses KhronosGroup#3566
MrSidims
force-pushed
the
SPV_ALTERA_arbitrary_precision_integers
branch
from
180f1d1 to
08b93cf
Compare
Comment on lines
+147
to
+149
| if (Ext == ExtensionID::SPV_INTEL_arbitrary_precision_integers) | ||
| return Opts.isAllowedToUseExtension( | ||
| ExtensionID::SPV_ALTERA_arbitrary_precision_integers); |
Contributor
There was a problem hiding this comment.
Should we also do the reverse? I.e. allowing INTEL when Ext is ALTERA?
Contributor
Author
There was a problem hiding this comment.
No, the reason this change was added is due to a required extension map in LLVMIntrinsicMapEntries. We don't want to do any expansion for i2/i4 when either SPV_INTEL_arbitrary_precision_integers or SPV_ALTERA_arbitrary_precision_integers is enabled. I don't want to rewrite a map to a multi-map, so added this utility function.
maarquitos14
approved these changes
Feb 24, 2026
YuriPlyakhin
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When both SPV_ALTERA_arbitrary_precision_integers and SPV_INTEL_arbitrary_precision_integers extensions are enabled - INTEL's version takes priority.
Addresses
#3566