Extend packed FP4/Int4 conversions for all container types#3618
Draft
vmaksimo wants to merge 1 commit intoKhronosGroup:mainfrom
Draft
Extend packed FP4/Int4 conversions for all container types#3618vmaksimo wants to merge 1 commit intoKhronosGroup:mainfrom
vmaksimo wants to merge 1 commit intoKhronosGroup:mainfrom
Conversation
`processMiniFPOrInt4Type` in SPIRVWriter was not handling `i16`, `i64`, and `<N x i8>` packed containers, causing an assert on forward translation. `OpSConvert` with an Int4 source in SPIRVReader was falling through to the generic SExt/Trunc path, causing `ConvertInt4ToInt8INTEL` to round-trip as a bare `sext`. Tests for `SPV_INTEL_float4` and `SPV_INTEL_int4` packed conversions are extended to cover all conversion instructions and container varieties.
Contributor
|
=>
|
vmaksimo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
processMiniFPOrInt4Typein SPIRVWriter was not handlingi16,i64, and<N x i8>packed containers, causing an assert on forward translation.OpSConvertwith an Int4 source in SPIRVReader was falling through to the generic SExt/Trunc path, causingConvertInt4ToInt8INTELto round-trip as a baresext.Tests for
SPV_INTEL_float4andSPV_INTEL_int4packed conversions are extended to cover all conversion instructions and container varieties.