Restore SPIRVUseTextFormat on error in readSpirv#3622
Open
vmaksimo wants to merge 1 commit intoKhronosGroup:mainfrom
Open
Restore SPIRVUseTextFormat on error in readSpirv#3622vmaksimo wants to merge 1 commit intoKhronosGroup:mainfrom
vmaksimo wants to merge 1 commit intoKhronosGroup:mainfrom
Conversation
Replace manual save/set/restore of SPIRVUseTextFormat with llvm::SaveAndRestore to guarantee restoration on all exit paths, including the early return on write error. Fixes Coverity CID 546125. Addresses KhronosGroup#3414
MrSidims
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace manual save/set/restore of
SPIRVUseTextFormatwithllvm::SaveAndRestoreto guarantee restoration on all exit paths, including the early return on write error.Fixes Coverity CID 546125.
Resolves #3414