Skip to content

Check for spirv-dis tool in DebugMacro tests #3648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MrSidims merged 3 commits into from
Mar 13, 2026
+13 −25
Merged

Check for spirv-dis tool in DebugMacro tests #3648

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ea429f6
Add missing 'REQUIRES: spirv-dis' to DebugMacro tests
aobolensk Mar 12, 2026
eb9476c
Address review comment
aobolensk Mar 12, 2026
1c6f2b4
Address review comment
aobolensk Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions test/DebugInfo/DebugMacroDef.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
; REQUIRES: spirv-dis
Copy link
Contributor

@MrSidims MrSidims Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it doable to wrap spirv-dis/spirv-val calls in a check like https://github.com/KhronosGroup/SPIRV-LLVM-Translator/pull/3564/changes#diff-c30d0043c2e721d7042d16318994ec28a8da880be606eb63869c1c305e8b0d4cR24 ?

Copy link
Contributor Author

@aobolensk aobolensk Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that is possible, applied

; Test round-trip translation of debug macro information:
; LLVM IR -> SPIR-V -> LLVM IR

Expand Down
1 change: 1 addition & 0 deletions test/DebugInfo/DebugMacroDefNoValue.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
; REQUIRES: spirv-dis
; This test exercises the case where the DICompileUnit has as !DIMacro with and without a value.
; It is not possible to distinguish the case between the macro with an empty value and without one.

Expand Down
1 change: 1 addition & 0 deletions test/DebugInfo/DebugMacroDefRoot.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
; REQUIRES: spirv-dis
; This test exercises the case where the DICompileUnit has as !DIMacro without a DIMacroFile

; Test round-trip translation of debug macro information:
Expand Down
1 change: 1 addition & 0 deletions test/DebugInfo/DebugMacroUndefinedUndef.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
; REQUIRES: spirv-dis
; This test exercises the cases where there is a DW_MACINFO_undef without a matching DW_MACINFO_def

; Test round-trip translation of debug macro information:
Expand Down