[LLVM-14] Use sret attribute syntax in IAddCarry/ISubBorrow tests#3657
Merged
vmaksimo merged 1 commit intoKhronosGroup:llvm_release_140from Mar 17, 2026
Merged
Conversation
Align the tests to its LLVM-15 and higher release versions. Otherwise, they fail with null pointer cast assertion in https://github.com/KhronosGroup/SPIRV-LLVM-Translator/blob/llvm_release_140/lib/SPIRV/SPIRVWriter.cpp#L5790
Contributor
Author
|
I'm not sure why the failure was not triggered earlier (no recent changes merged regarding these builtins), but now they fail in CI (e.g. in #3655, failing job example https://github.com/KhronosGroup/SPIRV-LLVM-Translator/actions/runs/23050854950/job/66951409354?pr=3655) |
svenvh
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align the tests to its LLVM-15 and higher release versions. Otherwise, they fail with null pointer cast assertion in https://github.com/KhronosGroup/SPIRV-LLVM-Translator/blob/llvm_release_140/lib/SPIRV/SPIRVWriter.cpp#L5790