Translate OpUndef to poison instead of undef in SPIR-V reader#3661
Open
aobolensk wants to merge 1 commit intoKhronosGroup:mainfrom
Open
Translate OpUndef to poison instead of undef in SPIR-V reader#3661aobolensk wants to merge 1 commit intoKhronosGroup:mainfrom
aobolensk wants to merge 1 commit intoKhronosGroup:mainfrom
Conversation
aobolensk
force-pushed
the
undef-to-poison
branch
from
23cce6e to
0eb7308
Compare
Contributor
Author
|
@MrSidims please, take a look |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLVM is migrating from undef to poison values. Update the OpUndef translation in SPIRVReader to produce PoisonValue instead of UndefValue.
Enable round-trip for
test/var_undef.llwhere the only difference between the approaches was related toundefvspoison