spirv-opt: Run tests second time with lower max id bound#6308
Closed
s-perron wants to merge 1 commit intoKhronosGroup:mainfrom
Closed
spirv-opt: Run tests second time with lower max id bound#6308s-perron wants to merge 1 commit intoKhronosGroup:mainfrom
s-perron wants to merge 1 commit intoKhronosGroup:mainfrom
Conversation
luciechoi
approved these changes
Sep 16, 2025
Contributor
|
What's the status of this PR? |
Collaborator
Author
|
Still a draft. I have a lot more passes to fix up before the tests will pass with this change. |
s-perron
force-pushed
the
id_overflow_tests
branch
from
084da97 to
f3a3540
Compare
The SinglePassRunAndCheck function duplicated logic from SinglePassRunAndDisassemble. This change refactors the former to call the latter, simplifying the implementation and improving maintainability. This allows us to have a central place where we can run tests a second time with a lower id bound that will guarentee an id overflow. We can test that the pass does not crash. This does not necessarily cover all code paths, but should cover most.
s-perron
force-pushed
the
id_overflow_tests
branch
from
f3a3540 to
d3bf5cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SinglePassRunAndCheck function duplicated logic from
SinglePassRunAndDisassemble. This change refactors the former to call the
latter, simplifying the implementation and improving maintainability.
This allows us to have a central place where we can run tests a second
time with a lower id bound that will guarentee an id overflow. We can
test that the pass does not crash.
This does not necessarily cover all code paths, but should cover most.