spirv-val: Improve Explicit Layout message#6331
Merged
alan-baker merged 2 commits intoKhronosGroup:mainfrom Sep 24, 2025
Merged
spirv-val: Improve Explicit Layout message#6331alan-baker merged 2 commits intoKhronosGroup:mainfrom
alan-baker merged 2 commits intoKhronosGroup:mainfrom
Conversation
Contributor
Author
|
@alan-baker friendly ping, mainly because I want to sneak this into the next SDK release and we are freezing the spirv commit friday |
alan-baker
reviewed
Sep 24, 2025
alan-baker
approved these changes
Sep 24, 2025
Contributor
|
I think the shaderc smoketest is unrelated to your change. |
Contributor
Author
|
@alan-baker I can rebase incase and try again |
0c545e5 to
85d3885
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #6323 and #6071
New messages now look like
and
Providing both the storage class and the decoration that makes it explicit layout should be enough, the whole details around which version make it valid or not-valid I think is overkill, the main thing is showing a SPIR-V generator what to look for