opt: Fix build issue with gcc 16#6542
Open
JoseExposito wants to merge 1 commit intoKhronosGroup:mainfrom
Open
Conversation
|
|
Compiling with gcc 16 throws this error:
FAILED: [code=1] source/opt/CMakeFiles/SPIRV-Tools-opt.dir/decoration_manager.cpp.o
source/opt/decoration_manager.cpp: In member function
‘spvtools::opt::analysis::DecorationManager::CloneDecorations(unsigned int, unsigned int)’:
source/opt/decoration_manager.cpp:546:27: error:
‘MEM[(unsigned int &)&op + 24]’ may be used uninitialized [-Werror=maybe-uninitialized]
546 | if (op.words[0] == from) { // add new pair of operands: (to, literal)
source/opt/decoration_manager.cpp:545:19: note: ‘op’ declared here
545 | Operand op = inst->GetOperand(i);
| ^~
cc1plus: all warnings being treated as errors
Make sure that the vector is not empty before using it.
JoseExposito
force-pushed
the
fix-gcc16-build-error
branch
from
fbd15e9 to
3116216
Compare
s-perron
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compiling with gcc 16 throws this error:
Make sure that the vector is not empty before using it.
Found while packaging it for Fedora:
https://koji.fedoraproject.org/koji/taskinfo?taskID=142384664