spirv-val: Add --allow-vulkan-linkage option#6580
Open
s-perron wants to merge 1 commit intoKhronosGroup:mainfrom
Open
spirv-val: Add --allow-vulkan-linkage option#6580s-perron wants to merge 1 commit intoKhronosGroup:mainfrom
s-perron wants to merge 1 commit intoKhronosGroup:mainfrom
Conversation
Adds a new option to spirv-val that permits the Linkage capability when targeting Vulkan environments. This is needed to validate SPIR-V generated by compilers that may still go through a linking process before being provided to the driver. * Adds `allow_vulkan_linkage` to `spv_validator_options_t`. * Updates C and C++ validator option APIs to support setting this flag. * Modifies `CapabilityPass` to allow `Capability Linkage` when targeting Vulkan if the option is enabled. * Exposes the new `--allow-vulkan-linkage` flag in the `spirv-val` CLI. * Adds corresponding tests for the new option and capability validation.
Contributor
|
I haven't looked at the code, but a question: does it make sense to just use universal validation until linking has occurred? Do you expect imported resources, etc? |
Contributor
|
Would it be simpler to just always always (only asking because I doubt the value of checking "ahead with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new option to spirv-val that permits the Linkage capability
when targeting Vulkan environments. This is needed to validate SPIR-V
generated by compilers that may still go through a linking process
before being provided to the driver.
allow_vulkan_linkagetospv_validator_options_t.CapabilityPassto allowCapability Linkagewhen targetingVulkan if the option is enabled.
--allow-vulkan-linkageflag in thespirv-valCLI.