spirv-val: Add Vulkan Image Format check

[spencer-lunarg]

4 years, and a 3rd try of #4748 and #5458 to get VUID-StandaloneSpirv-Image-04965 in

Last time this stalled on https://gitlab.khronos.org/spirv/SPIR-V/-/issues/766 / https://gitlab.khronos.org/spirv/SPIR-V/-/merge_requests/302/

[spencer-lunarg]

fatal error: generated SPIR-V is invalid: [VUID-StandaloneSpirv-Image-04965] Image Format type does not match Sample Type operand (float)
  %type_buffer_image_0 = OpTypeImage %float Buffer 2 0 0 1 Rgba16ui

note: please file a bug report on https://github.com/Microsoft/DirectXShaderCompiler/issues with source code if possible

@alan-baker I think this is catching a legit dxc bug?

[alan-baker]

@alan-baker I think this is catching a legit dxc bug?

Looks like it. The glslang test failure looks legit too.

[alan-baker]

@spencer-lunarg will you take care of the glslang update?

[spencer-lunarg]

will you take care of the glslang update?

yes, what is the process, I will have time to look for a fix in Monday

[alan-baker]

will you take care of the glslang update?

yes, what is the process, I will have time to look for a fix in Monday

I'm happy to either merge this now or wait till you have a fix. I leave it to you.

[spencer-lunarg]

@alan-baker I got the glslang hot fix up KhronosGroup/glslang#4190

[spencer-lunarg]

@alan-baker KhronosGroup/glslang#4191 was merged in, so GLSL is fixed now