opt: Fold OpCompositeExtract feeding from OpCopyLogical or OpLoad#6614
Open
s-perron wants to merge 1 commit intoKhronosGroup:mainfrom
Open
opt: Fold OpCompositeExtract feeding from OpCopyLogical or OpLoad#6614s-perron wants to merge 1 commit intoKhronosGroup:mainfrom
s-perron wants to merge 1 commit intoKhronosGroup:mainfrom
Conversation
- CopyLogicalFeedingExtract: Hoist OpCompositeExtract before OpCopyLogical. If the input to an OpCompositeExtract is an OpCopyLogical, we can extract from the original composite and then copy the result. - LoadFeedingExtract: Change OpLoad + OpCompositeExtract to OpAccessChain + OpLoad. If the input to an OpCompositeExtract is an OpLoad, we can load the specific element instead of the entire composite. This is restricted to non-Function/Private storage classes to avoid interfering with local-access-chain-convert. Updated fold_test.cpp with 8 new test cases and updated existing tests to use SPV_ENV_UNIVERSAL_1_5. Fixes KhronosGroup#6611
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the input to an OpCompositeExtract is an OpCopyLogical, we can
extract from the original composite and then copy the result.
If the input to an OpCompositeExtract is an OpLoad, we can load the
specific element instead of the entire composite. This is restricted
to non-Function/Private storage classes to avoid interfering with
local-access-chain-convert.
Updated fold_test.cpp with 8 new test cases and updated existing tests
to use SPV_ENV_UNIVERSAL_1_5.
Fixes #6611