Pr/riliang/opengl cts 4.6.0 subroutine #426
Open
+8
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Opengl cts 4.6.0
glGetUniformSubroutineuiv returns the value of the subroutine uniform at location <location>. The return value means the "subroutine index", not the "uniform location", so it can not compare the return value with location value. Affects: KHR-GL40.shader_subroutine.subroutine_uniform_reset Signed-off-by: Riliang Peng <riliang.peng@mthreads.com>
Contributor
Author
|
Please help to review, thanks. |
Contributor
Author
|
Could you please help to check? |
Contributor
|
Hi @Daylight-Peng, sorry for the delay. We are currently reviewing and testing this change in Khronos CI. |
Contributor
Author
Is it OK now? |
|
|
Contributor
|
Internal Khronos CL: https://gerrit.khronos.org/c/vk-gl-cts/+/17894 |
Contributor
|
Could you sign the CLA please? |
lordalcol
pushed a commit
that referenced
this pull request
Jan 23, 2026
glGetUniformSubroutineuiv returns the value of the subroutine uniform at location <location>. The return value means the "subroutine index", not the "uniform location", so it can not compare the return value with location value. Affects: KHR-GL40.shader_subroutine.subroutine_uniform_reset Public PR: #426 Change-Id: Icde7cf5c3e4d3a3ac758c96bd10d8049a0a5bbf3 Signed-off-by: Riliang Peng <riliang.peng@mthreads.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct glGetUniformSubroutineuiv return value comparison logic
glGetUniformSubroutineuiv returns the value of the subroutine uniform at
location .
The return value means the "subroutine index", not the "uniform location",
so it can not compare the return value with location value.
Affects:
KHR-GL40.shader_subroutine.subroutine_uniform_reset