Fixed a problem of B10G11R11 format #567
Open
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The LIMIT_FORMAT_BITMASK validation uses deUint32 for checking the limit value but incorrectly casts to deUint64 when logging the actual value. This causes incorrect values to be displayed in the logs. This bug was originally introduced in c82c0fa (2016) and persisted through the de* type removal in 1a09796 (2023).
…nt64-cast fix: incorrect uint64_t cast in bitmask limit validation
…nce it reads a IVec4 (128 bits) for one pixel.
|
yukang.wang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In terms of a DRM format
VK_FORMAT_B10G11R11_UFLOAT_PACK32. Once the CTS reads a IVec4 (128 bits) for one pixel, it will go out of boudary for the last pixel, because this format has only 32-bits packed.For more, on most OS (e.g. Win, Ubuntu), we can usually get a sort of clean memory from kernel. Then this problem would not happened. I tested this occuring in another minor platform (Linux on Arm64) where we are hitting dirty value at the last pixel.
Hope it will help the graphic software and hardware developers ~