Fix gles2 internalformat texture float tests #574
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The LIMIT_FORMAT_BITMASK validation uses deUint32 for checking the limit value but incorrectly casts to deUint64 when logging the actual value. This causes incorrect values to be displayed in the logs. This bug was originally introduced in c82c0fa (2016) and persisted through the de* type removal in 1a09796 (2023).
VK-GL-CTS/framework/delibs/deutil/deProcess.c: In function 'deProcess_create':
VK-GL-CTS/framework/delibs/deutil/deProcess.c:141:16: error: incompatible types when returning type '_Bool' but 'deProcess *' {aka 'struct deProcess_s *'} was expected
141 | return false;
| ^~~~~
Signed-off-by: _VIFEXTech <[email protected]>
…nt64-cast fix: incorrect uint64_t cast in bitmask limit validation
…rn_false Fixed the error in the return value type of deProcess_create
GL_RGB32F is not a valid parameter to teximage2D in gles2 context. Components: OpenGL Affected tests: KHR-GLES2.core.internalformat.texture2d.rgb_float_rgb*
|
|
Author
|
Alternative fix could be to require EDIT: or maybe not, the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GL_RGB32Fis not a valid parameter toteximage2Din gles2 context.Components: OpenGL
Affected tests:
KHR-GLES2.core.internalformat.texture2d.rgb_float_rgb*