Extra edge case for Storage Texel Buffer #326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I'll take a look and see what I can do to add that info somewhere.
…On Wed, Jul 9, 2025, 7:12 PM Spencer Fricke ***@***.***> wrote:
@spencer-lunarg <https://github.com/spencer-lunarg> requested your review
on: #326 <#326> Extra
edge case for Storage Texel Buffer.
—
Reply to this email directly, view it on GitHub
<#326 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA5IAY5M47IX5HBD4JZ37VL3HXDZ7AVCNFSM6AAAAACBFVNIGWVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJYGU2TMNBQGU2TSNY>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Contributor
Author
|
@gpx1000 realize you might be viewing from a phone, but this is a PR, not an issue |
Contributor
|
Ahhh yeah ok I'm reading while charging phone and over email. I'll look
when i get home
…On Wed, Jul 9, 2025, 7:42 PM Spencer Fricke ***@***.***> wrote:
*spencer-lunarg* left a comment (KhronosGroup/Vulkan-Guide#326)
<#326 (comment)>
@gpx1000 <https://github.com/gpx1000> realize you might be viewing from a
phone, but this is a PR, not an issue
—
Reply to this email directly, view it on GitHub
<#326 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA5IAY3XQWUS2LYZEQ7HQM33HXHJPAVCNFSM6AAAAACBFVNIGWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTANJVGEZDKMRTHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
gpx1000
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was using this awesome page today to explain storage texel buffers to someone and they made a mistake (which I swear I have done 2 or 3 times over the years) and not realizing that a R32 format only get a single component written and that GLSL has a strange quirk that it requires a
gvec4