CI: Separate header gen and sample stages #2441
Open
+42
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
asuessenbach
left a comment
asuessenbach
left a comment
There was a problem hiding this comment.
Just two questions:
| -D CMAKE_CXX_STANDARD=${{matrix.env.cxx_max}} \ | ||
| -D VULKAN_HPP_GENERATOR_BUILD=ON \ | ||
| -D VULKAN_HPP_RUN_GENERATOR=$RUN_GENERATOR \ | ||
| -D VULKAN_HPP_DISPATCH_LOADER_DYNAMIC=ON \ |
Contributor
There was a problem hiding this comment.
When you just build the generator and generate the headers, VULKAN_HPP_DISPATCH_LOADER_DYNAMIC should not be needed.
Contributor
Author
There was a problem hiding this comment.
It may not be needed, but the Vulkan::Hpp that will always be created uses find_package(Vulkan) if we do not enable the dynamic dispatcher. This suppresses warnings (and potential issues) when it cannot be found (CI), so I left it there.
.github/workflows/build.yml
Outdated
| -D VULKAN_HPP_RUN_GENERATOR=OFF \ | ||
| -D VULKAN_HPP_SAMPLES_BUILD=ON \ | ||
| -D VULKAN_HPP_TESTS_BUILD=OFF \ | ||
| -D VULKAN_HPP_TESTS_CTEST=ON \ |
Contributor
There was a problem hiding this comment.
Why is VULKAN_HPP_TESTS_CTEST on here?
Contributor
Author
There was a problem hiding this comment.
It has no effect, but I can explicitly disable it for the sake of consistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had previously merged them to be concise, but separating these has two distinct time advantages:
This pretty much covers all the ideas I had for reducing these runner times and will (hopefully) be the last PR about them for a while..