Add spaceship operator for vk handles#2498
Merged
asuessenbach merged 1 commit intoKhronosGroup:mainfrom Feb 23, 2026
Merged
Conversation
Contributor
|
Looks good, even with manual adjustments in vulkan.hpp. Have you used clang-format 21.1.0? |
Contributor
Author
|
No, mine is 18.1.8, gonna update it. |
Contributor
Author
|
Right, 21.1.8 gives a clean diff, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some comparisons rely on implicit conversions (#2001), which do not work when
VULKAN_HPP_TYPESAFE_CONVERSION=0(which is default on 32-bit platforms).Specifically, compilation fails with
VULKAN_HPP_TYPESAFE_CONVERSION=0andVULKAN_HPP_HAS_SPACESHIP_OPERATOR, because structs try to use the spaceship operator for comparing their member handles.For instance, vk::PipelineShaderStageCreateInfo:
Note that I did not run the generator - clang-format gave me a crazy diff for some reason, so I patched
vulkan_handles.hppby hand.