Merge ResultValue with specializations#2499
Merged
asuessenbach merged 1 commit intoKhronosGroup:mainfrom Feb 24, 2026
Merged
Conversation
Contributor
|
That's a nice little simplification. Thanks for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of
ResultValuediverged with its specializations for unique handles: base class hasstd::expected-like functions and specializations haveasTuple()function. The specializations are mostly boilerplate, as they are identical, with exception of the specialized type, meaning that they can easily be merged with the base class.So I brought rvalue variant of
asTuple()into the base class and dropped the specializations.This means that I have also dropped lvalue
asTuple()variant, which was deprecated for a few years already: #1605This should hopefully simplify the maintenance without needing to keep the base class and specializations in sync.
And it also helps with other use cases, like
ResultValue<std::pair<...>>variant (YaaZ/VulkanMemoryAllocator-Hpp#78), which would otherwise require one more specialization.Note that I did not run the generator - clang-format gave me a crazy diff for some reason, so I patched vulkan.hpp by hand.