Skip to content

Silence warnings for wrong manifest type#1650

Merged
charles-lunarg merged 1 commit intoKhronosGroup:mainfrom
charles-lunarg:dont_warn_on_shared_app_package_path
Feb 3, 2025
Merged

Silence warnings for wrong manifest type#1650
charles-lunarg merged 1 commit intoKhronosGroup:mainfrom
charles-lunarg:dont_warn_on_shared_app_package_path

Conversation

@charles-lunarg
Copy link
Collaborator

If the loader happens upon a layer/ICD manifest while searching for manifests of the opposite type, do not emit warnings. These are spurious and only cause users to think something is wrong with the installation when it is actually fine.

@ci-tester-lunarg
Copy link

CI Vulkan-Loader build queued with queue ID 363769.

@ci-tester-lunarg
Copy link

CI Vulkan-Loader build queued with queue ID 363787.

@charles-lunarg charles-lunarg linked an issue Feb 3, 2025 that may be closed by this pull request
@ci-tester-lunarg
Copy link

CI Vulkan-Loader build # 2889 running.

@charles-lunarg charles-lunarg force-pushed the dont_warn_on_shared_app_package_path branch from 413a19a to 278289b Compare February 3, 2025 20:41
@ci-tester-lunarg
Copy link

CI Vulkan-Loader build queued with queue ID 363828.

@ci-tester-lunarg
Copy link

CI Vulkan-Loader build # 2891 running.

@ci-tester-lunarg
Copy link

CI Vulkan-Loader build # 2891 failed.

If the loader happens upon a layer/ICD manifest while searching for manifests
of the opposite type, do not emit warnings. These are spurious and only cause
users to think something is wrong with the installation when it is actually
fine.
@charles-lunarg charles-lunarg force-pushed the dont_warn_on_shared_app_package_path branch from 278289b to b9e867a Compare February 3, 2025 22:47
@ci-tester-lunarg
Copy link

CI Vulkan-Loader build queued with queue ID 363905.

@ci-tester-lunarg
Copy link

CI Vulkan-Loader build queued with queue ID 363922.

@ci-tester-lunarg
Copy link

CI Vulkan-Loader build # 2893 running.

@ci-tester-lunarg
Copy link

CI Vulkan-Loader build # 2893 passed.

@charles-lunarg charles-lunarg merged commit aad266e into KhronosGroup:main Feb 3, 2025
44 checks passed
@charles-lunarg charles-lunarg deleted the dont_warn_on_shared_app_package_path branch February 3, 2025 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove misleading ICD/layer warnings

2 participants

Comments