Skip to content

Comments

Adjust color attachment barrier for dynamic rendering local read sample#1255

Merged
marty-johnson59 merged 1 commit intoKhronosGroup:mainfrom
SaschaWillems:dr_local_read_barriers
Jan 13, 2025
Merged

Adjust color attachment barrier for dynamic rendering local read sample#1255
marty-johnson59 merged 1 commit intoKhronosGroup:mainfrom
SaschaWillems:dr_local_read_barriers

Conversation

@SaschaWillems
Copy link
Collaborator

Description

This PR slightly adjusts the barrier for the color attachment in the dynamic rendering local read sample so it matches the one from the (non local read) dynamic rendering sample. See the latest comment in #983

General Checklist:

Please ensure the following points are checked:

  • My code follows the coding style
  • I have reviewed file licenses
  • I have commented any added functions (in line with Doxygen)
  • I have commented any code that could be hard to understand
  • My changes do not add any new compiler warnings
  • My changes do not add any new validation layer errors or warnings
  • I have used existing framework/helper functions where possible
  • My changes do not add any regressions
  • I have tested every sample to ensure everything runs correctly
  • This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

  • I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

If this PR contains framework changes:

  • [n/a] I did a full batch run using the batch command line argument to make sure all samples still work properly

@marty-johnson59 marty-johnson59 merged commit b3cb382 into KhronosGroup:main Jan 13, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants