Fix portability errors and null device crash on macOS/iOS for hello_triangle_1_3#1268
Merged
marty-johnson59 merged 2 commits intoKhronosGroup:mainfrom Feb 24, 2025
Merged
Conversation
SaschaWillems
approved these changes
Feb 12, 2025
gpx1000
approved these changes
Feb 12, 2025
gary-sweet
approved these changes
Feb 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes portability errors and null device crash on macOS for hello_triangle_1_3 sample. Even though MoltenVK does not yet support Vulkan 1.3, these errors cause batch mode to fail on macOS. This PR fixes the issues so the sample can start and terminate cleanly and batch mode can run to completion properly.
Fixes #1267.
Tested on macOS Ventura with Vulkan SDK 1.4.304.0. Portability changes protected by
VKB_ENABLE_PORTABILITY, exactly the same as in the hello_triangle sample.General Checklist:
Please ensure the following points are checked:
Note: The Samples CI runs a number of checks including:
If this PR contains framework changes:
batchcommand line argument to make sure all samples still work properlySample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist: