Skip to content

Comments

Fix portability errors and null device crash on macOS/iOS for hello_triangle_1_3#1268

Merged
marty-johnson59 merged 2 commits intoKhronosGroup:mainfrom
SRSaunders:hello_tri_13-macos
Feb 24, 2025
Merged

Fix portability errors and null device crash on macOS/iOS for hello_triangle_1_3#1268
marty-johnson59 merged 2 commits intoKhronosGroup:mainfrom
SRSaunders:hello_tri_13-macos

Conversation

@SRSaunders
Copy link
Contributor

@SRSaunders SRSaunders commented Feb 3, 2025

Description

Fixes portability errors and null device crash on macOS for hello_triangle_1_3 sample. Even though MoltenVK does not yet support Vulkan 1.3, these errors cause batch mode to fail on macOS. This PR fixes the issues so the sample can start and terminate cleanly and batch mode can run to completion properly.

Fixes #1267.

Tested on macOS Ventura with Vulkan SDK 1.4.304.0. Portability changes protected by VKB_ENABLE_PORTABILITY, exactly the same as in the hello_triangle sample.

General Checklist:

Please ensure the following points are checked:

  • My code follows the coding style
  • I have reviewed file licenses
  • I have commented any added functions (in line with Doxygen)
  • I have commented any code that could be hard to understand
  • My changes do not add any new compiler warnings
  • My changes do not add any new validation layer errors or warnings
  • I have used existing framework/helper functions where possible
  • My changes do not add any regressions
  • I have tested every sample to ensure everything runs correctly
  • This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

  • I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

If this PR contains framework changes:

  • I did a full batch run using the batch command line argument to make sure all samples still work properly

Sample Checklist

If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

  • I have tested the sample on at least one compliant Vulkan implementation
  • If the sample is vendor-specific, I have tagged it appropriately
  • I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms
  • Any dependent assets have been merged and published in downstream modules
  • For new samples, I have added a paragraph with a summary to the appropriate chapter in the readme of the folder that the sample belongs to e.g. api samples readme
  • For new samples, I have added a tutorial README.md file to guide users through what they need to know to implement code using this feature. For example, see conditional_rendering
  • For new samples, I have added a link to the Antora navigation so that the sample will be listed at the Vulkan documentation site

@marty-johnson59 marty-johnson59 merged commit 2e7caa5 into KhronosGroup:main Feb 24, 2025
19 checks passed
@SRSaunders SRSaunders deleted the hello_tri_13-macos branch February 26, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Portability errors and null device crash on macOS for hello_triangle_1_3

5 participants