Skip to content

Comments

Use correct device feature in multi draw indirect sample documentation#1271

Merged
marty-johnson59 merged 1 commit intoKhronosGroup:mainfrom
SaschaWillems:mdi_fix_1266
Feb 24, 2025
Merged

Use correct device feature in multi draw indirect sample documentation#1271
marty-johnson59 merged 1 commit intoKhronosGroup:mainfrom
SaschaWillems:mdi_fix_1266

Conversation

@SaschaWillems
Copy link
Collaborator

Description

This PR fixes the documentation for the multi draw indirect sample to check for the correct device feature (multiDrawIndirect instead of bufferDeviceAddress).

Note: Documentation only PR, no code changes.

Fixes #1266

General Checklist:

Please ensure the following points are checked:

  • My code follows the coding style
  • I have reviewed file licenses
  • I have commented any added functions (in line with Doxygen)
  • I have commented any code that could be hard to understand
  • My changes do not add any new compiler warnings
  • My changes do not add any new validation layer errors or warnings
  • I have used existing framework/helper functions where possible
  • My changes do not add any regressions
  • I have tested every sample to ensure everything runs correctly
  • This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

  • I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

If this PR contains framework changes:

  • I did a full batch run using the batch command line argument to make sure all samples still work properly

@SaschaWillems SaschaWillems added the documentation Improvements or additions to documentation label Feb 4, 2025
@marty-johnson59 marty-johnson59 merged commit deb3e20 into KhronosGroup:main Feb 24, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong struct in MultiDrawIndirect documentation example

4 participants