-
Notifications
You must be signed in to change notification settings - Fork 781
update the actions/cache version for ios to v4 #1292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update the actions/cache version for ios to v4 #1292
Conversation
|
@gpx1000, while you are at it should you update the Vulkan SDK version in the iOS CI script to 1.4.304, or perhaps latest? iOS is the only build target that requires linking to the SDK (for the iOS Vulkan framework). What will happen if the SDK is not in the cache, and needs to fall back to the retrieve action, but it does not match (or is lower than) the Vulkan Headers in the project? Will we get a version mismatch conflict at build or runtime? I am concerned about the breaking changes with the DynamicLoader namespace in #1281 causing issues here with earlier SDK versions. |
SaschaWillems
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻 . As per discussion we should merge this ASAP in order to get PRs to properly build again.
|
OK, merging. LMK if it causes issues |
@marty-johnson59 It's causing issues for me at least. See #1297 |
|
Bummer. @gpx1000, can you investigate? Do we need to revert? |
|
Is reverting possible? The reason for this PR Was that the submodule for astc did point to a no longer existing commit, and to my understanding that broke fresh cleanouts :/ |
|
I might have a way to fix this for you; I might have pulled from the wrong tag to what were previously using. I'll try going back to that tag instead. |
Description
Fix the CI/CD build for ios by updating the cache
Fixes #
General Checklist:
Please ensure the following points are checked:
Note: The Samples CI runs a number of checks including:
If this PR contains framework changes:
batchcommand line argument to make sure all samples still work properlySample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist: