Skip to content

Conversation

@gpx1000
Copy link
Collaborator

@gpx1000 gpx1000 commented Mar 10, 2025

Description

Fix the CI/CD build for ios by updating the cache

Fixes #

General Checklist:

Please ensure the following points are checked:

  • My code follows the coding style
  • I have reviewed file licenses
  • I have commented any added functions (in line with Doxygen)
  • I have commented any code that could be hard to understand
  • My changes do not add any new compiler warnings
  • My changes do not add any new validation layer errors or warnings
  • I have used existing framework/helper functions where possible
  • My changes do not add any regressions
  • I have tested every sample to ensure everything runs correctly
  • This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

  • I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

If this PR contains framework changes:

  • I did a full batch run using the batch command line argument to make sure all samples still work properly

Sample Checklist

If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

  • I have tested the sample on at least one compliant Vulkan implementation
  • If the sample is vendor-specific, I have tagged it appropriately
  • I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms
  • Any dependent assets have been merged and published in downstream modules
  • For new samples, I have added a paragraph with a summary to the appropriate chapter in the readme of the folder that the sample belongs to e.g. api samples readme
  • For new samples, I have added a tutorial README.md file to guide users through what they need to know to implement code using this feature. For example, see conditional_rendering
  • For new samples, I have added a link to the Antora navigation so that the sample will be listed at the Vulkan documentation site

@SRSaunders
Copy link
Contributor

SRSaunders commented Mar 10, 2025

@gpx1000, while you are at it should you update the Vulkan SDK version in the iOS CI script to 1.4.304, or perhaps latest?

iOS is the only build target that requires linking to the SDK (for the iOS Vulkan framework). What will happen if the SDK is not in the cache, and needs to fall back to the retrieve action, but it does not match (or is lower than) the Vulkan Headers in the project? Will we get a version mismatch conflict at build or runtime? I am concerned about the breaking changes with the DynamicLoader namespace in #1281 causing issues here with earlier SDK versions.

- name: Load VulkanSDK from cache
        id: VulkanSDK
        uses: actions/cache@v4
        with:
          path: VulkanSDK
          key: vulkan

      - name: retrieve VulkanSDK
        if: steps.VulkanSDK.outputs.cache-hit != 'true'
        run: |
          wget https://sdk.lunarg.com/sdk/download/1.3.290.0/mac/vulkansdk-macos-1.3.290.0.dmg
          sudo hdiutil attach vulkansdk-macos-1.3.290.0.dmg
          sudo /Volumes/vulkansdk-macos-1.3.290.0/InstallVulkan.app/Contents/MacOS/InstallVulkan --root ~/VulkanSDK --accept-licenses --default-answer --confirm-command install com.lunarg.vulkan.ios
          sudo hdiutil detach /Volumes/vulkansdk-macos-1.3.290.0

@SaschaWillems SaschaWillems self-requested a review March 10, 2025 17:57
Copy link
Collaborator

@SaschaWillems SaschaWillems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻 . As per discussion we should merge this ASAP in order to get PRs to properly build again.

@marty-johnson59
Copy link
Contributor

OK, merging. LMK if it causes issues

@marty-johnson59 marty-johnson59 merged commit bbb427f into KhronosGroup:main Mar 10, 2025
19 checks passed
@gary-sweet
Copy link
Contributor

gary-sweet commented Mar 12, 2025

OK, merging. LMK if it causes issues

@marty-johnson59 It's causing issues for me at least. See #1297

@marty-johnson59
Copy link
Contributor

Bummer. @gpx1000, can you investigate? Do we need to revert?

@SaschaWillems
Copy link
Collaborator

Is reverting possible? The reason for this PR Was that the submodule for astc did point to a no longer existing commit, and to my understanding that broke fresh cleanouts :/

@gpx1000
Copy link
Collaborator Author

gpx1000 commented Mar 12, 2025

I might have a way to fix this for you; I might have pulled from the wrong tag to what were previously using. I'll try going back to that tag instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants