Skip to content

Conversation

@SaschaWillems
Copy link
Collaborator

Description

We were stll using 1.3 headers. As Vulkan.hpp did have some breaking changes and deprecations, people using recent headers and looking at our samples had issues with code not working.

This PR updates the Vulkan headers (incl. Vulkan.hpp) and Volk to 1.4.311.

It also changes some framework classes and sample code to accompany breaking changes and deprecation warnings in Vulkan.pp.

General Checklist:

Please ensure the following points are checked:

  • My code follows the coding style
  • I have reviewed file licenses
  • I have commented any added functions (in line with Doxygen)
  • I have commented any code that could be hard to understand
  • My changes do not add any new compiler warnings
  • My changes do not add any new validation layer errors or warnings
  • I have used existing framework/helper functions where possible
  • My changes do not add any regressions
  • I have tested every sample to ensure everything runs correctly
  • This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

  • I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

If this PR contains framework changes:

  • I did a full batch run using the batch command line argument to make sure all samples still work properly

@SaschaWillems SaschaWillems added the framework This is relevant to the framework label Mar 21, 2025
@SaschaWillems
Copy link
Collaborator Author

This is obvious pretty much a slightly never version of #1281, but also contains fixes for very recent header changes and removals.

@SRSaunders
Copy link
Contributor

This is obvious pretty much a slightly never version of #1281...

While hpp_instance.cpp is updated, this PR seems to be missing the debug_utils_messenger_callback() namespace updates from #1281 which are located in hpp_hello_triangle.cpp. Perhaps they should be added...

As you indicate above, this is a newer fix for issue #1269.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

framework This is relevant to the framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants