Make vkb::sg::Node a unified class vkb::scene_graph::Node<bindingType>

[asuessenbach]

Description

Next class unified between C- and C++-bindings.

This "unification" without a prior HPP-version of Node is necessary to unify classes that actually use this Node class.

Build tested on Win10 with VS2022. Run tested on Win10 with NVidia GPU.

General Checklist:

Please ensure the following points are checked:

• My code follows the coding style
• I have reviewed file licenses
• I have commented any added functions (in line with Doxygen)
• I have commented any code that could be hard to understand
• My changes do not add any new compiler warnings
• My changes do not add any new validation layer errors or warnings
• I have used existing framework/helper functions where possible
• My changes do not add any regressions
• I have tested every sample to ensure everything runs correctly
• This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

• I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
• My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

If this PR contains framework changes:

• I did a full batch run using the batch command line argument to make sure all samples still work properly

Sample Checklist

If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

• I have tested the sample on at least one compliant Vulkan implementation
• If the sample is vendor-specific, I have tagged it appropriately
• I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms
• Any dependent assets have been merged and published in downstream modules
• For new samples, I have added a paragraph with a summary to the appropriate chapter in the readme of the folder that the sample belongs to e.g. api samples readme
• For new samples, I have added a tutorial README.md file to guide users through what they need to know to implement code using this feature. For example, see conditional_rendering
• For new samples, I have added a link to the Antora navigation so that the sample will be listed at the Vulkan documentation site

[SaschaWillems]

LGTM

[gary-sweet]

The conditional_rendering sample is very messed up with this change for some reason.
It's not supposed to look like this:

[asuessenbach]

The conditional_rendering sample is very messed up with this change for some reason.

Indeed! That needs some closer investigation. Marking this PR as a draft, for now.

[SaschaWillems]

Sadly my C++ skills aren't good enough to describe or fix the underlying issue, but when debugging it looks the dynamic cast to `NodeC´ for child/parent relations fails. Which matches the missing rotations/translations in the conditional rendering sample.

In void Transform::update_world_transform():

auto parent = node.get_parent();

Calls into inline Node<bindingType> *Node<bindingType>::get_parent(). This function does a dynamic cast:

return dynamic_cast<NodeC *>(parent);

That dynamic cast fails and as such returns NULL instead.

[asuessenbach]

That dynamic cast fails and as such returns NULL instead.

Great catch! That dynamic_cast needs to be a reinterpret_cast.
I'm a bit puzzled that no compiler did at least warn about that.

[gary-sweet]

Looks better now, thanks