Skip to content

Conversation

@SaschaWillems
Copy link
Collaborator

@SaschaWillems SaschaWillems commented Oct 27, 2025

Description

As discussed on the last sample call, always setting queue priorities to 1.0f (max.) is not a good practice. This PR adjusts all places where queue priorities are set to use 0.5f instead. Won't make a difference anyway, as we rarely (if at all) use multiple queues from the same family.

Refs KhronosGroup/Vulkan-Tutorial#166

General Checklist:

Please ensure the following points are checked:

  • My code follows the coding style
  • I have reviewed file licenses
  • I have commented any added functions (in line with Doxygen)
  • I have commented any code that could be hard to understand
  • My changes do not add any new compiler warnings
  • My changes do not add any new validation layer errors or warnings
  • I have used existing framework/helper functions where possible
  • My changes do not add any regressions
  • I have tested every sample to ensure everything runs correctly
  • This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

  • I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

If this PR contains framework changes:

  • I did a full batch run using the batch command line argument to make sure all samples still work properly

@asuessenbach
Copy link
Contributor

I've probably missed something, but why is a queuePriority of 1.0f not a good practice?
As we never have more than one queue from the same family, the actual value doesn't make any difference. Why not keeping it at 1.0f?

@SaschaWillems
Copy link
Collaborator Author

We discussed this on one of our recent calls and agreed to change/make it consistent across all samples (and the tutorial). This is similar to other computing areas where telling people to set the highest priority for a resource is usually considered bad practice. People will copy that and at some point might wonder why things don't work out.

gary-sweet
gary-sweet previously approved these changes Nov 3, 2025
Copy link
Contributor

@gary-sweet gary-sweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might have gone with 0.5, but 0.0 shouldn't cause any problems.

@SaschaWillems SaschaWillems changed the title Set default queue priorities to 0.0f Set default queue priorities to 0.5f Nov 8, 2025
@marty-johnson59 marty-johnson59 merged commit 2ab57ee into main Dec 1, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants