-
Notifications
You must be signed in to change notification settings - Fork 792
Add a new sample for VK_EXT_device_fault #1447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I see a bunch of compilation errors when I try to build this: |
|
@gary-sweet All fixed and pushed the changes. |
|
Can you move the shaders to a subdirectory called "glsl"? We support different shading languages and the goal is for all samples to have shaders in different shading languages (glsl, slang and/or hlsl). |
|
This does build ok for me now, and correctly reports as not-supported. I can't say any more than that though. |
|
@SaschaWillems Hello, I've just received errors regarding Quality Checks / Copyright Headers Check in the files I haven't modified. Should I fix them or is it related to CI needs a fixing? |
|
As per yesterdays call we'll ignore the CI failure caused by files you didn't touch. We'll try to make that CI step more robust/less error prone. |
|
Hi @melihmete, per discussion today, this is almost ready to merge. Just needs the copyright header addressed and the merge conflict resolved. When those are ready, I'll merge. Thanks! |
60df65e
| // Log each address info with decimal and hexadecimal representations | ||
| for (uint32_t i = 0; i < faultCount.addressInfoCount; i++) { | ||
| LOGE("Fault Address Info Address Type: {}", std::to_string(addressInfos[i].addressType)); | ||
| LOGE("Fault Address Info Reported Address -> Decimal: {} | Hex: 0x{:X}", addressInfos[i].reportedAddress, static_cast<uint64_t>(addressInfos[i].reportedAddress)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably include the addressPrecision field here, as the reportedAddress may represent a range of addresses (for example, a page).
Description
When developing Vulkan applications, understanding and handling GPU errors is crucial. Currently, traditional graphics debugging methods do not give detailed information about GPU faults.
The VK_EXT_device_fault extension provides detailed information when ERROR_DEVICE_LOST occur, while the VK_EXT_device_address_binding_report extension helps monitor GPU memory usage by reporting
allocated and bound/unbound addresses in Vulkan application.
General Checklist:
Please ensure the following points are checked:
Note: The Samples CI runs a number of checks including:
If this PR contains framework changes:
batchcommand line argument to make sure all samples still work properlySample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist: