Skip to content

vkcubepp: Support protected output#1078

Merged
charles-lunarg merged 1 commit intoKhronosGroup:mainfrom
gnoliyil:protected_output
Mar 6, 2025
Merged

vkcubepp: Support protected output#1078
charles-lunarg merged 1 commit intoKhronosGroup:mainfrom
gnoliyil:protected_output

Conversation

@gnoliyil
Copy link
Contributor

This change was originally introduced into Fuchsia's Vulkan-Tools fork in https://fxrev.dev/c/third_party/Vulkan-Tools/+/444614.

If --protected_output command line option is specified, vkcubepp will render to the protected memory.

Bug: https://fxbug.dev/378964821

@ci-tester-lunarg
Copy link

Author gnoliyil not on autobuild list. Waiting for curator authorization before starting CI build.

1 similar comment
@ci-tester-lunarg
Copy link

Author gnoliyil not on autobuild list. Waiting for curator authorization before starting CI build.

@CLAassistant
Copy link

CLAassistant commented Feb 16, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@charles-lunarg charles-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

This change was originally introduced into Fuchsia's Vulkan-Tools
fork in https://fxrev.dev/c/third_party/Vulkan-Tools/+/444614.

If `--protected_output` command line option is specified, vkcubepp
will render to the protected memory.

Bug: https://fxbug.dev/378964821
Change-Id: I11c89d3d722236448edd41ca51a03f80d0ba7324
@ci-tester-lunarg
Copy link

Author gnoliyil not on autobuild list. Waiting for curator authorization before starting CI build.

1 similar comment
@ci-tester-lunarg
Copy link

Author gnoliyil not on autobuild list. Waiting for curator authorization before starting CI build.

@ci-tester-lunarg
Copy link

CI Vulkan-Tools build queued with queue ID 377419.

@ci-tester-lunarg
Copy link

CI Vulkan-Tools build # 1627 running.

@ci-tester-lunarg
Copy link

CI Vulkan-Tools build # 1627 failed.

@gnoliyil
Copy link
Contributor Author

#1079 (vkcubepp: Support Fuchsia) has been merged since last review. I uploaded a new version of this PR to include the Fuchsia-specific manifest files to run the tests in protected mode on Fuchsia. Please take a look?

Copy link
Contributor

@charles-lunarg charles-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay, Vulkanized took over my schedule for a bit, and I've been working through the backlog ever since.

@charles-lunarg charles-lunarg merged commit dd0c2e4 into KhronosGroup:main Mar 6, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants