Version check vulkan headers #1156
Merged
+13
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI Vulkan-Tools build queued with queue ID 532281. |
|
CI Vulkan-Tools build queued with queue ID 532296. |
|
CI Vulkan-Tools build # 1808 running. |
|
CI Vulkan-Tools build # 1808 passed. |
charles-lunarg
force-pushed
the
version_check_vulkan_headers
branch
from
b3885a9 to
f7702ef
Compare
|
CI Vulkan-Tools build queued with queue ID 532877. |
|
CI Vulkan-Tools build queued with queue ID 532892. |
|
CI Vulkan-Tools build # 1810 running. |
|
CI Vulkan-Tools build # 1810 passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things: Codegen the 'current generated version' into CMake's
project()field, and use that version to specify the 'minimum VulkanHeader's version required' infind_package. This turns the cryptic compile errors from compiling with too-old Vulkan-Headers into a clear build failure with a specific error message.Example error message