-
Notifications
You must be signed in to change notification settings - Fork 187
build: Update to header 1.4.327 #1159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CI Vulkan-Tools build queued with queue ID 534480. |
1 similar comment
|
CI Vulkan-Tools build queued with queue ID 534480. |
|
CI Vulkan-Tools build # 1814 running. |
|
CI Vulkan-Tools build # 1814 failed. |
|
CI Vulkan-Tools build queued with queue ID 534745. |
1 similar comment
|
CI Vulkan-Tools build queued with queue ID 534745. |
|
CI Vulkan-Tools build # 1816 running. |
|
CI Vulkan-Tools build # 1816 passed. |
|
@charles-lunarg vulkaninfo video code was broken by the presence of a vendor extension. I have a workaround but I don't particularly like it. Any thoughts on the proper way to fix this? |
vulkaninfo typically excludes vendor extensions, but video extensions are excluded from this. The extension categories struct definitions now have a new member 'ignore_vendor_exclusions' to control whether that category include vendor extensions.
82cf936 to
ead516b
Compare
|
CI Vulkan-Tools build queued with queue ID 535166. |
1 similar comment
|
CI Vulkan-Tools build queued with queue ID 535166. |
|
@mikes-lunarg Found the source of the issue. Vulkaninfo excludes vendor only extensions in its output. VAVLE is a vendor, so the type was prevented from being generated. However, the video code is complicated and rather interdependent. I would rather allow video codegen to use all available types in order to fix this. There aren't many vendor video extensions, unlike VkPhysicalDeviceFeatures2 which has hundreds. |
|
CI Vulkan-Tools build # 1819 running. |
|
CI Vulkan-Tools build # 1819 passed. |
I like that a lot better, thanks! |
No description provided.