cube: Fix xlib window close #1160
Merged
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI Vulkan-Tools build queued with queue ID 534996. |
|
CI Vulkan-Tools build queued with queue ID 535011. |
|
CI Vulkan-Tools build # 1818 running. |
|
CI Vulkan-Tools build # 1818 passed. |
Contributor
|
I don't mind the change, but could I get a 1 line description of what the problem is? Best to put it in the commit message. |
XSetVMProtocols is needed to register WM_DELETE_WINDOW. Without this the window close event was never received. The window was still destroyed and vkAcquireNextImageKHR returned VK_ERROR_SURFACE_LOST_KHR
ziga-lunarg
force-pushed
the
ziga-fix-xlib-window-close
branch
from
9554722 to
a03448a
Compare
|
CI Vulkan-Tools build queued with queue ID 535184. |
|
CI Vulkan-Tools build queued with queue ID 535199. |
charles-lunarg
approved these changes
Sep 20, 2025
Contributor
charles-lunarg
left a comment
charles-lunarg
left a comment
There was a problem hiding this comment.
Ahh this makes a lot of sense now! Thanks for the quick fix :D
|
CI Vulkan-Tools build # 1821 running. |
|
CI Vulkan-Tools build # 1821 passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.