Codegen rewrite to use Vulkan-Object #1164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI Vulkan-Tools build queued with queue ID 547182. |
|
CI Vulkan-Tools build queued with queue ID 547197. |
|
CI Vulkan-Tools build # 1833 running. |
Structs were only checking the first alias when deciding the display name to use. Now, pNext chains consider all aliases. Additionally, --show-promoted-structs now includes printing aliased types, whereas before it would only work for 'completely distinct aliases', eg the structs are different types instead of being C typedefs.
charles-lunarg
force-pushed
the
vulkan_object
branch
from
033e469 to
e2e5523
Compare
|
CI Vulkan-Tools build queued with queue ID 547214. |
|
CI Vulkan-Tools build # 1834 running. |
|
CI Vulkan-Tools build # 1834 passed. |
|
|
||
| # File Comment | ||
| out.append('// *** THIS FILE IS GENERATED - DO NOT EDIT ***\n') | ||
| out.append('// See vulkan_tools_helper_file_generator.py for modifications\n') |
Contributor
There was a problem hiding this comment.
Suggested change
| out.append('// See vulkan_tools_helper_file_generator.py for modifications\n') | |
| out.append(f'// See {os.path.basename(__file__)} for modifications\n') |
nit
spencer-lunarg
approved these changes
Oct 4, 2025
Contributor
spencer-lunarg
left a comment
spencer-lunarg
left a comment
There was a problem hiding this comment.
I don't get paid to write Python for a living, this isn't how I would have wrote the code, but it is very readable and a good use of Vulkan-Object and would actually be willing to touch this code gen in the future... so ya, got my approval
Contributor
Author
|
Did some additional testing and found no showstopping issues, going ahead with the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.