cube: Fix crash with VK_GOOGLE_display_timing #1175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were referencing present_time and ptime past their lifetimes in the block, resulting in corruption of the pNext chain.
That's already the check for the block we're under.
|
Author anholt not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
|
Author anholt not on autobuild list. Waiting for curator authorization before starting CI build. |
|
|
charles-lunarg
approved these changes
Nov 14, 2025
|
CI Vulkan-Tools build queued with queue ID 579074. |
|
CI Vulkan-Tools build # 1858 running. |
|
CI Vulkan-Tools build # 1858 passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were referencing present_time and ptime past their lifetimes in the
block, resulting in corruption of the pNext chain.