Remove deprecated Findtinygltf.cmake file#99
Conversation
- Include `VulkanHpp` in CMake configuration.
- Update Vulkan module inclusion paths to use `${VulkanHpp_CPPM_DIR}` over `${Vulkan_INCLUDE_DIR}` for consistency.
- Add checks for `VULKAN_SDK` environment variable with warnings and fallback handling. - Enhance Vulkan SDK detection with alternative paths and auto-setup for missing libraries or targets. - Add CMake logic to validate and create `vulkan.cppm` for `VulkanHpp` if not found. - Ensure all necessary directories and dependencies exist, providing meaningful error messages otherwise.
- Extract Vulkan SDK version from environment variable. - Add cache-based version detection to identify changes. - Clear related CMake cache entries on version update. - Cache the current Vulkan SDK version for future checks.
- Update workflow to create and manage Vulkan SDK version-specific symlinks on Linux. - Remove outdated version caching logic from `CMakeLists.txt`.
- Add logic to create or update `vulkan.cppm` with improved namespace exports. - Handle detection and modification of system `vulkan.cppm` files. - Include script for fixing outdated `vulkan.cppm` implementations.
- Introduce `fix_vulkan_cppm.cmake` to detect and fix `vulkan.cppm` files using outdated formats. - Ensure proper handling of `detail` namespace imports to align with updated standards. - Add logic to manage write permissions and create modified copies when required.
|
I've also been having the issue that @asuessenbach mentioned regarding this file. I'm on Windows, and for whatever reason that FindTinyGLTF.cmake does some very weird things so that I always have to delete and fresh clone the repo. To test this PR, all I did:
And just by doing that I get the following diff: 
That feels very odd/wrong. Not sure what's causing this on Windows, but also not sure how to tell if this actually fixes the issue. |
|
hmm... maybe we need to rename it to the lower case and drop the camel case. Windows + fetch_content... strange things happening. Not sure what's causing it. |
|
Yeah. weird indeed. If I do a 'git reset --hard', the change disappears. But then git switch to main and git switch back to this PR magically makes that diff appear again :/ |
|
The actual issue here is, that Windows is inherently case insensitive. I would assume that, if one of the two Find*.cmake files is gone and you freshly clone this repo, every problem around that file should be gone. |
|
Still not entirely sure what exactly was wrong, but combo of reverting, forcing the naming to be correct and getting gltf to be happy seems to have fixed CI. Please give this a try and see if it solves your problems in Windows. |
|
Still the same issue when doing a clean checkout with main: As soon as I switch to any branch (including this), it has the issue with the Findtinygltf.cmake file name. I think we need to merge in order to properly test this in Windows as the issue is in main. |
|
Okay, merging, it can't be worse than it currently is ;-) |
|
Looking good. Just did a clean checkout, switched to a branch without any issues. |
3 participants
No description provided.