layers: Add VK_QCOM_data_graph_model extension support and unit tests #11577

ZZKQcom · 2026-01-29T09:13:58Z

Add VK_QCOM_data_graph_model extension validation in VVL.
Add VK_QCOM_data_graph_model extension positive and negative unit tests.
Run vk_layer_validation_tests on Qualcomm SM8750/SM8850 device, pass all unit tests (include new added data graph model unit tests) except some unsupported tests (skip).
Run vk_layer_validation_tests on Test Driver and Profiles layer, skip on some unsupported tests, fail on some NegativeTensor tests provided by ARM, but they have nothing to do with the code change, they are associated with the wrong usages of tensor and external memory.

ci-tester-lunarg · 2026-01-29T09:14:01Z

Author ZZKQcom not on autobuild list. Waiting for curator authorization before starting CI build.

CLAassistant · 2026-01-29T09:14:08Z

All committers have signed the CLA.

layers/core_checks/cc_device.cpp

tests/unit/data_graph_model_positive.cpp

tests/unit/data_graph_model.cpp

layers/state_tracker/device_state.cpp

layers/core_checks/cc_device.cpp

…t tests

ci-tester-lunarg · 2026-01-30T11:41:42Z

Author ZZKQcom not on autobuild list. Waiting for curator authorization before starting CI build.

spencer-lunarg · 2026-01-30T14:23:13Z

layers/core_checks/cc_data_graph.cpp

+    bool has_identical_op = false;
+    bool has_identical_paired_op_engine = false;
+
+    std::vector<uint32_t> data_graph_queue_families{};


Suggested change

std::vector<uint32_t> data_graph_queue_families{};

vvl::unordered_set<uint32_t> data_graph_queue_families{};

spencer-lunarg · 2026-01-30T14:24:42Z

layers/core_checks/cc_data_graph.cpp

+        }
+    }
+
+    if (!has_identical_paired_op_engine) {


is this suppose to still be an error if data_graph_queue_families is empty?

A comment saying (and an assert(!data_graph_queue_families.empty());) to say otherwise that if we are in this function, there is a guaranteed VK_QUEUE_DATA_GRAPH_BIT_ARM

spencer-lunarg · 2026-01-30T14:26:36Z

layers/core_checks/cc_data_graph.cpp

+    }
+
+    if (!has_identical_paired_op_engine) {
+        std::string conditional_string{};


use std::stringstream ss; like we do for other errors we want to print a more complex, conditional based, error message

spencer-lunarg · 2026-01-30T14:27:39Z

layers/core_checks/cc_data_graph.cpp

    }

+    // Defer validate VkPipelineCacheHeaderVersionDataGraphQCOM of VkPipelineCache
+    // TODO: may exist potential issues


what are "potential issues" here, please elaborate, if it is a spec issue, please provide a link to it here in the comment

spencer-lunarg · 2026-01-30T14:31:24Z

layers/stateless/sl_command_pool.cpp

+    const auto &error_obj = context.error_obj;
+
+    if (const auto* processing_engine_info =
+        vku::FindStructInPNextChain<VkDataGraphProcessingEngineCreateInfoARM>(pCreateInfo->pNext); processing_engine_info) {


extra declaration is not needed

Suggested change

vku::FindStructInPNextChain<VkDataGraphProcessingEngineCreateInfoARM>(pCreateInfo->pNext); processing_engine_info) {

vku::FindStructInPNextChain<VkDataGraphProcessingEngineCreateInfoARM>(pCreateInfo->pNext)) {

spencer-lunarg · 2026-01-30T15:36:11Z

tests/unit/data_graph_model.cpp

+
+    m_errorMonitor->SetDesiredError("VUID-VkPipelineCacheHeaderVersionDataGraphQCOM-headerSize-11836");
+    {
+        auto pipeline_cache = BuildPipelineCacheWithInvalidHeaderSize(*this);


I really don't want these "one time only " function, all of these are basically the test logic, but I now have to go bounce around to see what is going on

if you can't find a reason to use the "test helper" functions more than once, it is not a helper... it is the test, so please just inline here

spencer-lunarg · 2026-01-30T15:37:43Z

tests/unit/data_graph_model_positive.cpp

+    }
+
+    // Record and execute command packets
+    VkDataGraphPipelineDispatchInfoARM data_graph_pipeline_dispatch_info{


search VK_STRUCTURE_TYPE in this PR, they all should be using vku::InitStructHelper();

spencer-lunarg · 2026-01-30T15:37:59Z

tests/unit/data_graph_model_positive.cpp

+    DGModelPipelineLayoutInfo dg_pipeline_layout_info = BuildGeneralPipelineLayout(layer_test);
+
+    // Data graph pipeline create information
+    VkDataGraphPipelineCreateInfoARM data_graph_pipeline_ci = vku::InitStructHelper();


Suggested change

VkDataGraphPipelineCreateInfoARM data_graph_pipeline_ci = vku::InitStructHelper();

VkDataGraphPipelineCreateInfoARM data_graph_pipeline_ci = vku::InitStructHelper(&identifier_ci);

spencer-lunarg · 2026-01-30T15:39:34Z

tests/unit/data_graph_model_positive.cpp

+    command_buffer_allocate_info.commandPool = command_pool;
+    command_buffer_allocate_info.commandBufferCount = 1;
+    command_buffer_allocate_info.level = VK_COMMAND_BUFFER_LEVEL_PRIMARY;
+    vkt::CommandBuffer command_buffer{ *m_device, command_buffer_allocate_info };


Suggested change

vkt::CommandBuffer command_buffer{ *m_device, command_buffer_allocate_info };

vkt::CommandBuffer command_buffer{ *m_device, command_pool };

spencer-lunarg · 2026-01-30T15:41:06Z

tests/unit/data_graph_model_positive.cpp

+    DGModelTensorInfo output_tensor_info = BuildTensor(*this, output_tensor_description);
+
+    // Create command pool
+    VkCommandPoolCreateInfo command_pool_ci = vku::InitStructHelper();


Suggested change

VkCommandPoolCreateInfo command_pool_ci = vku::InitStructHelper();

VkCommandPoolCreateInfo command_pool_ci = vku::InitStructHelper(&dg_processing_engine_ci);

ZZKQcom requested a review from a team as a code owner January 29, 2026 09:13

spencer-lunarg requested changes Jan 29, 2026

View reviewed changes

ZZKQcom added 2 commits January 30, 2026 19:39

layers: Add VK_QCOM_data_graph_model extension support and unit tests

fd792d4

fixup! layers: Add VK_QCOM_data_graph_model extension support and uni…

46894b3

…t tests

ZZKQcom force-pushed the graph_pipeline_ext branch from afb1b3b to 46894b3 Compare January 30, 2026 11:41

ZZKQcom requested a review from spencer-lunarg January 30, 2026 12:10

spencer-lunarg requested changes Jan 30, 2026

View reviewed changes

	std::vector<uint32_t> data_graph_queue_families{};
	vvl::unordered_set<uint32_t> data_graph_queue_families{};

	vku::FindStructInPNextChain<VkDataGraphProcessingEngineCreateInfoARM>(pCreateInfo->pNext); processing_engine_info) {
	vku::FindStructInPNextChain<VkDataGraphProcessingEngineCreateInfoARM>(pCreateInfo->pNext)) {

	VkDataGraphPipelineCreateInfoARM data_graph_pipeline_ci = vku::InitStructHelper();
	VkDataGraphPipelineCreateInfoARM data_graph_pipeline_ci = vku::InitStructHelper(&identifier_ci);

	vkt::CommandBuffer command_buffer{ *m_device, command_buffer_allocate_info };
	vkt::CommandBuffer command_buffer{ *m_device, command_pool };

	VkCommandPoolCreateInfo command_pool_ci = vku::InitStructHelper();
	VkCommandPoolCreateInfo command_pool_ci = vku::InitStructHelper(&dg_processing_engine_ci);

layers: Add VK_QCOM_data_graph_model extension support and unit tests #11577

Are you sure you want to change the base?

layers: Add VK_QCOM_data_graph_model extension support and unit tests #11577

Uh oh!

Conversation

ZZKQcom commented Jan 29, 2026

Uh oh!

ci-tester-lunarg commented Jan 29, 2026

Uh oh!

CLAassistant commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ci-tester-lunarg commented Jan 30, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

CLAassistant commented Jan 29, 2026 •

edited

Loading