Implement GL_EXT_long_vector#4132
Merged
dnovillo merged 3 commits intoKhronosGroup:mainfrom Jan 7, 2026
Merged
Conversation
jeffbolznv
commented
Dec 18, 2025
3e82d38 to
ba601af
Compare
dnovillo
requested changes
Jan 2, 2026
Collaborator
dnovillo
left a comment
There was a problem hiding this comment.
Looks fine overall.
- For coopvecNV, I think we allow conversions from/to vector types. Is this still true? Maybe add a test for this.
- I did not see a test for GL_EXT_buffer_reference for long vectors. That's allowed, I think?
- long vectors in uniform and buffer blocks are not allowed, right? I don't think we are validating this (or even testing?)
layout(constant_id = 0) const uint N = 5;
layout(set=0, binding=0, std140) uniform UBO {
vector<float, N> v; // I think this should be invalid?
};
Contributor
Author
Yes, conversions are allowed. There's some testing for this in spv.longVector.comp:testfuncs() (including parameter passing).
This was missing, I've added it to spv.longVectorStorage.comp.
This is allowed, it's tested in spv.longVectorStorage.comp. I'll push an update shortly. |
dnovillo
approved these changes
Jan 5, 2026
Collaborator
dnovillo
left a comment
There was a problem hiding this comment.
Thanks. OK to go in as soon as the SPIRV-Tools changes have been submitted to ToT.
dnovillo
approved these changes
Jan 7, 2026
Collaborator
dnovillo
left a comment
There was a problem hiding this comment.
Thanks for the update. Will submit as soon as the bots finish.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GLSL spec: KhronosGroup/GLSL#297
SPIR-V spec: KhronosGroup/SPIRV-Registry#377