Skip to content

Only set afterType when a token is recognized as a keyword#4142

Merged
dnovillo merged 2 commits intoKhronosGroup:mainfrom
jeffbolznv:vector_reserved
Jan 13, 2026
Merged

Only set afterType when a token is recognized as a keyword#4142
dnovillo merged 2 commits intoKhronosGroup:mainfrom
jeffbolznv:vector_reserved

Conversation

@jeffbolznv
Copy link
Copy Markdown
Contributor

Fixes #4139.

I did this for most existing keywords, but not for the sampler stuff because the logic is somewhat different and there are some existing warnings that it raises.

@jeroenbakker-atmind
Copy link
Copy Markdown

This PR seems to fix the issue. (tested a single shader)

Current main

$ ./glslang ./overlay_volume_velocity_needle.vert.glsl --target-env vulkan1.2
./overlay_volume_velocity_needle.vert.glsl
ERROR: overlay_volume_velocity_vert.glsl:59: 'vector' : undeclared identifier 
ERROR: overlay_volume_velocity_vert.glsl:59: '' : compilation terminated 
ERROR: 2 compilation errors.  No code generated.


ERROR: Linking vertex stage: No function definition (body) found: 
    main_function_(

SPIR-V is not generated for failed compile or link

With PR

$ ./glslang ./overlay_volume_velocity_needle.vert.glsl --target-env vulkan1.2
./overlay_volume_velocity_needle.vert.glsl
$

Copy link
Copy Markdown
Collaborator

@dnovillo dnovillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM.

@dnovillo dnovillo merged commit 7881226 into KhronosGroup:main Jan 13, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Common reserved keyword vector

3 participants