Implement <system> include for the standalone wrapper#4154
Implement <system> include for the standalone wrapper#4154dnovillo merged 8 commits intoKhronosGroup:mainfrom
Conversation
dneto0
left a comment
There was a problem hiding this comment.
This should be testable. Please add tests.
|
I have added a test, please check if it is sufficient. I'm not entirely sure about the local inclusion search algorithm currently implemented though. It will search in the directories of the includers if not found in current source directory (see Test/inc1/foo.h, which includes Test/parent.h). I doubt whether this is how C/C++ preprocessors work, but I have reused this algorithm for system inclusions. |
dnovillo
left a comment
There was a problem hiding this comment.
Thanks for the improvement! Some test suggestions:
- A GLSL test
- A negative test for unresolved system includes.
Two more tests are added! Please tell me if more or more robust tests are needed. |
dnovillo
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the new tests.
This pull request adds
#include <system>directive support for the standalone wrapper as specified in theARB_shading_language_includeextension.The current spec seems to give the implementation a lot of liberties on how to resolve the inclusion paths, similar to the C/C++ standard. This PR implements this directive similar to the GCC preprocessor:
-Iflag, in left-to-right order;