Implement extension GL_EXT_descriptor_heap.#4155
Implement extension GL_EXT_descriptor_heap.#4155jeremy-lunarg merged 1 commit intoKhronosGroup:mainfrom
Conversation
|
|
ShchchowAMD
force-pushed
the
EXT_descriptor_heap
branch
from
3d51e73 to
5a5ce11
Compare
|
@ShchchowAMD I started cleaning up some warning/errors but when I got to the error, |
|
We need to update the
|
|
Hi, sorry for the late reply, I'll fix them today, thanks for reminding and all the help yesterday! Sorry for those issues not found before in my local. |
|
Just removed unused variable and parameters in this PR. They are wrongly be kept during development, current implementation for decorating structure heap type is finished. |
jeremy-lunarg
left a comment
jeremy-lunarg
left a comment
There was a problem hiding this comment.
Some questions but otherwise looks okay.
ShchchowAMD
force-pushed
the
EXT_descriptor_heap
branch
from
2a10ee0 to
cd624f1
Compare
|
Rebased and clean up commented extension macro declaration. |
|
@ShchchowAMD Thanks for the rebase. I was in the middle of doing that as well, but appreciate you taking over. Please squash your commits into a single commit to help triage future bisects. |
ShchchowAMD
force-pushed
the
EXT_descriptor_heap
branch
from
cd624f1 to
1820c7f
Compare
|
@jeremy-lunarg Hi, I squash those commits and ready to merge now. But I found I may don't have access to process merge operation here. |
|
Thanks for the fixes, rebase, and squash! |
4 participants
Support GL_EXT_descriptor_heap in glslang.