Implement support for GL_NV_push_constant_bank#4157
Merged
dnovillo merged 9 commits intoKhronosGroup:mainfrom Jan 22, 2026
Merged
Implement support for GL_NV_push_constant_bank#4157dnovillo merged 9 commits intoKhronosGroup:mainfrom
dnovillo merged 9 commits intoKhronosGroup:mainfrom
Conversation
dnovillo
reviewed
Jan 22, 2026
Collaborator
dnovillo
left a comment
dnovillo
left a comment
There was a problem hiding this comment.
LGTM with some minor changes that can be done post-submission. For tests, perhaps add a negative test and one with edge cases (e.g., using maximum bank index, or not specifying bank
dnovillo
approved these changes
Jan 22, 2026
Collaborator
dnovillo
left a comment
dnovillo
left a comment
There was a problem hiding this comment.
Thanks for the fixes. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.